Change zeit to vercel, add vercel config files #818
Conversation
styles/icons.less
Outdated
| @@ -924,7 +924,7 @@ | |||
| .yorick-icon:before { .fi; content: "\1f480";top: 2px; } | |||
| .yui-icon:before { .fi; content: "\ea00"; top: 2px; } | |||
| .zbrush-icon:before { .fi; content: "\e9f2"; top: 2px; font-size: 16px; } | |||
| .zeit-icon:before { .fi; content: "\25B2"; top: 2px; } | |||
| .vercel-icon:before { .fi; content: "\25B2"; top: 2px; } | |||
There was a problem hiding this comment.
Users who've modified the .zeit-icon class in their stylesheets will lose any customisations, so it's better to leave this unchanged.
There was a problem hiding this comment.
Thanks for quick response! Totally makes sense, fixed it 🙂
config.cson
Outdated
| Zeit: | ||
| icon: "zeit" | ||
| Vercel: | ||
| icon: "vercel" |
There was a problem hiding this comment.
We should keep an alias for the old name:
Vercel:
icon: "zeit"
+ alias: "Zeit"In addition, see my comment below (on styles/icons.less).
config.cson
Outdated
| @@ -6780,11 +6780,13 @@ fileIcons: | |||
| [".ztl", "auto-red", alias: "ZBrush tool"] | |||
| ] | |||
|
|
|||
| Zeit: | |||
| icon: "zeit" | |||
| Vercel: | |||
There was a problem hiding this comment.
We keep this list sorted alphabetically, so the Vercel entry needs to come before Verilog.
config.cson
Outdated
| [/^vercel\.json$/i, "auto-grey", priority: 2, uses: "JSON"] | ||
| [".vercelignore", "auto-maroon", uses: "Ignore List"] |
There was a problem hiding this comment.
Might be better to merge these into the existing entries:
match: [
[/^(vercel|now)\.json$/i, "auto-grey", priority: 2, uses: "JSON"]
[/^\.(vercel|now)ignore$/i, "auto-maroon", uses: "Ignore List"]
]
|
Perfect! Thank you! 👍 |
|
Hey @Alhadis is there any possibility that this change will be pushed to the VSCode package in the near future? |
|
Hey @bibixx, sorry. I haven't had time to publish any release recently, which I hope to rectify tonight (seeing as my ability to get online is somewhat… sporadic lately). Don't worry, I always publish an update to both Atom and VSCode's package registries at the same time (so they don't fall out of sync). |
|
Also, posting this purely because I have nowhere else to share it:
You know GitHub's running out of recs when it starts recommending your own projects… |
|
Sorry for the wait, I had to finish the obligatory pre-release icon scrounging ritual. 😉 You should see v1.0.25 in VSCode's extension updates panel. 👍 |
Motivation
Recently Zeit has been renamed to Vercel (https://vercel.com/blog/zeit-is-now-vercel). Because of that they have introduced new filenames –
vercel.json(previouslynow.json) and.vercelignore(previously.nowignore).This PR introduces