fix: wait for async command exit (#1326)

This prevents the accumulation of zombie processes when using async (&) event commands. Also log async command failures.
filebrowser · Mar 14, 2021 · 6d5ceae · 6d5ceae
1 parent 381f090
commit 6d5ceae
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/runner/runner.go b/runner/runner.go
@@ -102,6 +102,14 @@ func (r *Runner) exec(raw, evt, path, dst string, user *users.User) error {
 
 	if !blocking {
 		log.Printf("[INFO] Nonblocking Command: \"%s\"", strings.Join(command, " "))
+		defer func() {
+			go func() {
+				err := cmd.Wait()
+				if err != nil {
+					log.Printf("[INFO] Nonblocking Command \"%s\" failed: %s", strings.Join(command, " "), err)
+				}
+			}()
+		}()
 		return cmd.Start()
 	}