Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.16 no longer follows symlink #1488

Closed
princemaple opened this issue Jul 29, 2021 · 8 comments
Closed

2.16 no longer follows symlink #1488

princemaple opened this issue Jul 29, 2021 · 8 comments
Labels
bug 🐞 Something isn't working

Comments

@princemaple
Copy link
Contributor

Description
Opening a symlink to a folder no longer works

Expected behaviour
in 2.15 it works

What is happening instead?

500 read /path/to/target/location is a directory

Additional context
N/A

How to reproduce?

ln -s some_where some_link

try and open some_link

Files
N/A

@princemaple
Copy link
Contributor Author

Thanks!

@Andoramb
Copy link

Andoramb commented Aug 6, 2021

Hi!
I'm on 2.16.1 (docker) symlinks are still considered a file
image

@ramiresviana
Copy link
Contributor

Hi!
I'm on 2.16.1 (docker) symlinks are still considered a file
image

Are you able to access the link using a shell? Invalid links will be shown as a file on FileBrowser.

@Andoramb
Copy link

Andoramb commented Aug 9, 2021

Hi @ramiresviana
You're right, I also cannot open symlinks (running filebrowser in docker). However symlinks are ok on the host. Has it something to do with permissions? UID/GID?
Thanks :)

@Andoramb
Copy link

Andoramb commented Aug 9, 2021

Attaching the same folders in docker-compose works without problem.
As for the symlinks: ls -al shows the original path for the folders, which is inaccessible of course from within the container.

EDIT: another strange behavior: in docker compose: by adding
- "${MEDIA}/DATA2:/srv/media"
to the volume, the app creates empty folders on the host at "/srv/media"

Alsan pushed a commit to Alsan/filebrowser that referenced this issue Aug 25, 2021
@Nepherim
Copy link

Looks like this is still an issue. Path is navigable from the OS, but the link shows as a file in FB. Happy to help with log info, etc.

rahul-r pushed a commit to rahul-r/filebrowser that referenced this issue Sep 2, 2022
@ParronS3
Copy link

Hello, sorry for the refloating.I was having the same error. 2 symlinks i had were working, but the new I was trying to make was not.
imagen

I had solved it. The difference was that the woking ones were pointing from a relative route, the one thas i was creating was from an absolute one
imagen

@scambier
Copy link

scambier commented Mar 26, 2024

I'm having the same issue, but relative or absolute links don't seem to make a difference. I'm on 2.27.0.

If the symlink target is a folder that is already available from Filebrowser, it works. If the target is outside, the link is shown as incorrect. The folder's owner is the same in both cases, if that matters.

Edit: I guess it's due to Docker to having rights to "outside" folders?

Edit2: It works as expected when Filebrowser is not executed through Docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants