Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Setting: Disable used percentage #2136

Merged
merged 16 commits into from
Feb 15, 2023
Merged

New Setting: Disable used percentage #2136

merged 16 commits into from
Feb 15, 2023

Conversation

AlencarGabriel
Copy link
Contributor

@AlencarGabriel AlencarGabriel commented Sep 20, 2022 •
edited
Loading

Description

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

Hi! I propose this PR to meet a need that we had and could be useful to the community.

Hiding the disk usage percentage graph was necessary to omit the total size of an NFS volume in Kubernetes, which could be misinterpreted or misused by users.

I built the new configuration entirely based on the existing branding.disableExternal.

I remain at your disposal for further clarifications, and I await its approval and publication.

@AlencarGabriel
Copy link
Contributor Author

Hi @o1egl , any news for this PR?

@AlencarGabriel
Copy link
Contributor Author

Interested in this PR?

@zoidy
Copy link

zoidy commented Oct 26, 2022

I'd like to see this merged. Perhaps also create a PR in the documentation repo to document this new functionality?

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 26, 2022
@AlencarGabriel
Copy link
Contributor Author

Interested in this PR?

@github-actions github-actions bot removed the Stale label Nov 30, 2022
@AlencarGabriel
Copy link
Contributor Author

@o1egl , @hacdias , @Equim-chan ?

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@AlencarGabriel
Copy link
Contributor Author

Could @o1egl have a look, please? At least one positive or negative return?

@github-actions github-actions bot removed the Stale label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 2, 2023
@AlencarGabriel
Copy link
Contributor Author

Please @hacdias / @o1egl / @ramiresviana , any feedback? Several issues and PRs being closed, and this one without any feedback

@zoidy
Copy link

zoidy commented Feb 2, 2023

Please @hacdias / @o1egl / @ramiresviana , any feedback? Several issues and PRs being closed, and this one without any feedback

It seems like devs are probably too busy with other things to look at new features, evidenced by the fact that many recent merges are just tiny bug fixes or translation updates (a response of any kind would be helpful though). While I would have liked to have your feature merged, perhaps it's time to maintain your own fork with your own features and just pull from upstream when needed.

o1egl
o1egl requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@o1egl o1egl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve the merge conflicts and fix the linting errors?

@AlencarGabriel
Copy link
Contributor Author

@o1egl conflicts and linting erros fixed.

@github-actions github-actions bot removed the Stale label Feb 3, 2023
@AlencarGabriel
Copy link
Contributor Author

@o1egl I didn't know the commit policy when I opened the PR. Do I need to rewrite all commits to proceed with the merge?

o1egl
o1egl requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@o1egl o1egl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When display usage is disabled, the API request is still sent to the server. I think we shouldn't do this

thewh1teagle and others added 9 commits February 6, 2023 14:44
@thewh1teagle @AlencarGabriel
fix: missing video controls on mobile (filebrowser#2180)
9eca23b
@dependabot @AlencarGabriel
build(deps): bump ansi-html and webpack-dev-server in /frontend (file…
2b009b3 
…browser#2184)

Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer used after updating ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies need to be updated together.


Removes `ansi-html`

Updates `webpack-dev-server` from 3.11.2 to 3.11.3
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/v3.11.3/CHANGELOG.md)
- [Commits](webpack/webpack-dev-server@v3.11.2...v3.11.3)

---
updated-dependencies:
- dependency-name: ansi-html
  dependency-type: indirect
- dependency-name: webpack-dev-server
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@o1egl @AlencarGabriel
chore(release): 2.23.0
01ee413
@freakingeek @AlencarGabriel
refactor: replace username old focus logic with the autofocus attribu…
8efa0c8 
…te (filebrowser#2223)
@brlarini @AlencarGabriel
chore: update pt-br translations (filebrowser#2248)
2645edf
@davquar @AlencarGabriel
chore: update Italian translation (filebrowser#2260)
eb128f9
@gyuris @AlencarGabriel
feat: add Hungarian translation (filebrowser#2232)
715658c
@AlencarGabriel
fix: lint fixes
4cfccb0
@AlencarGabriel
fix: don't request API when disableUsedPercentage: true
537258b
@AlencarGabriel
Copy link
Contributor Author

When display usage is disabled, the API request is still sent to the server. I think we shouldn't do this

@o1egl , I maked rebase for fix lint-commits, and fixed request API when config is disabled.

@o1egl o1egl merged commit 428c1c6 into filebrowser:master Feb 15, 2023
@AlencarGabriel
Copy link
Contributor Author

Thanks @o1egl for this approval! I'm happy to have contributed to this project.

Shada pushed a commit to Shada/filebrowser that referenced this pull request Apr 10, 2023
@AlencarGabriel @Shada
feat: add a new setting that disables the display of the disk usage (f…
5a92df0 
…ilebrowser#2136)
@CorySanin CorySanin mentioned this pull request Jul 29, 2023
Closed
@putty182 putty182 mentioned this pull request Aug 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o1egl o1egl Awaiting requested review from o1egl o1egl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@AlencarGabriel @zoidy @o1egl @Ltzhu76 @thewh1teagle @sbouchex @freakingeek @brlarini @davquar @gyuris