fix: missing video controls on mobile #2180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix related to this issue #2166
I checked this browsers:
Chrome
Brave
Firefox
And it happened in all of them, no controls of videos.
I tested this fix and it worked in these 3 browsers.
To test it by yourself:
Simply open any video in filebrowser with your android browser.
I found the reason for the problem and the solution here:
https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-web.html