fix: missing video controls on mobile #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this is better than "overflow: auto"? |
AlencarGabriel
pushed a commit
to AlencarGabriel/filebrowser
that referenced
this pull request
Feb 6, 2023
Shada
pushed a commit
to Shada/filebrowser
that referenced
this pull request
Feb 22, 2023
Shada
pushed a commit
to Shada/filebrowser
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix related to this issue #2166
I checked this browsers:
ChromeBraveFirefoxAnd it happened in all of them, no controls of videos.
I tested this fix and it worked in these 3 browsers.
To test it by yourself:
Simply open any video in filebrowser with your android browser.
I found the reason for the problem and the solution here:
https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-web.html