-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to upload files #2593
Comments
This issue is currently worked on #2145 |
I see Issue #2145 is merged but issue still persists. Using v2.24.1 with cloudflared |
I am having same issue. Can't upload anything at all because of this issue. Also using cloudflare here. @TobiasGoerke any thoughts? Using cloudflare the issue happens, but I can successfully upload large files locally. |
I'll pass this on to @o1egl, who refactored the upload handling in 1769fb1, introducing this bug. I've seen the URL being assembled incorrectly when using a
#2145 was the PR that introduced the issue. |
Not sure if this is the same issue, but I'm unable to upload any file either locally or through Cloudflare since updating. I seem to get a 403: Running on Raspberry Pi 4B, 64bit Pi OS, tested with Chrome and Firefox |
This appears to be addressed by #2598. |
happening to me too :) |
Happening here too. |
Still happens with v2.24.2 and, apparently, non-admin scoped users with only create, remove, download, edit permissions, whichever might provoke this... Admin uploads work. Edit: nevermind, edit actually wasn't there (: I thought that's only for the text editor... |
filebrowser:v2.24.2 works for me |
This is still happening as of 2.24.2, uploads either locally or remotely don't work, and give the same error, but only for non admin users
|
This linne should be responsible. Are you sure your user has all required privileges, like modifying and viewing files? |
It appears that guests being unable to edit files is what was causing this, enabling the setting for the guest account appears to fix! |
Hello liljohn360, where can i setting? please help. |
Log into your admin account and go to settings > user management |
Hello, |
Hello |
This is my setup:
Yet I get this error: The file I try to upload is about 40MB, my trunk size is set to 80MB. So this actually should not create junks. Whatever I upload, log prints:
I uploaded files that everywhere else work. Some SOOC, also the Filebrowser logo. It does not take it. Btw: using Cloudflare Enterprise. So trunks will not be needed anyway - yet no option to turn it off. I like trunks, but they seem not to work. |
I'm getting the same 405 error also using Cloudflare |
I just saw that in the original Thread (#2145) this already was reported: #2145 (comment) @TobiasGoerke is there any chance, you might have a look at this? Thanks in advance! |
Cloudflare blocks HEAD requests, thereby causing this issue. IIRC there are some temp fixes listed in on of the issues here. |
Please provide the HTTP response information. You can locate it in the network tab of the browser developer console. According to the cloudflare docs, it shouldn't cache responses if |
I believe that disabling Cloudflare CDN might not resolve the issue effectively; it would be more of a workaround. Furthermore, I am inclined to retain Cloudflare due to the numerous benefits it offers.
Thank you for your assistance. Below, you will find the requested HTTP response information: Here are the pertinent requests: Request 1 (
Request 2 (
As mentioned by @TobiasGoerke, the issue appears to be related to the HEAD request, which Cloudflare does not directly allow on cachable requests. To address this, it may be beneficial to modify the request to use a standard GET request and then extract the header or terminate the request after obtaining the header. Continuing to use HEAD requests will likely result in failure, as Cloudflare converts them to GET requests for cacheable resources. More information on this behavior can be found here. For those using Cloudflare who are unwilling to wait for a workaround or fix, you can create a Cloudflare PageRule with the following settings:
This will allow you to upload immediately, as no cache can be applied to these URLs, and therefore the HEAD request can not be cacheable - ergo: will not be converted to a GET request. |
@o1egl thanks! |
closes filebrowser#2593 (cherry picked from commit 36af01d)
closes filebrowser#2593 (cherry picked from commit 36af01d)
closes filebrowser#2593 (cherry picked from commit 36af01d)
I had this issue today, and enabling "edit" works for me. But I still think "edit" should be a separate permission. I should not need to enable "edit" to let people upload files. This issue was not presented until I updated filebrowser to the latest version. So this might still be an issue that needs to be addressed. |
Setting this page rule in Cloudflare worked for me. Thanks. |
Description
Tried uploading a file on my local network from my computer desktop, but received an "Upload failed: Error: tus: unable to resume upload (new upload cannot be created without an endpoint), originated from request (method: HEAD, url: /api/tus/filename.pdf override=false, response code:405, response text: ,request id:n/a)"
Expected behaviour
I would expect to be able to upload the file without error.
What is happening instead?
A zero byte file is created with the above error message displayed in red.
Additional context
How to reproduce?
Happens every time I try to upload a file starting today, August 1, 2023 after updating File Browser this morning.
Files
The text was updated successfully, but these errors were encountered: