Onlyoffice #1420
Onlyoffice #1420
Conversation
|
Is there a reason why there is no feedback to this? |
|
onlyoffice is suopported ? it can be integrated with filebrowser? |
|
I would love to see this implemented ! |
|
Thank you so much, best feature ever |
|
This looks great, thank you for your work, hope this could be merged soon. |
|
Can we get this merged? |
|
Is it possible to open the file in read-only (viewer mode)? (by OnlyOffice of course) |
|
Hello, is this something that the development team is considering merge it in the near future? If so, that would be a massive update. |
|
This addition would make FileBrowser much better : it was one of the things I preferred in Filestash, before I installed FileBrowser |
| )}?auth=${this.jwt}`; | ||
| let key = Date.parse(this.req.modified).toString() + url.encodePath(this.req.path); | ||
| key = key.replaceAll(/[-_.!~[\]*'()/,;:\-%+.]/g, ""); |
There was a problem hiding this comment.
might want a comment explaining this regex, it's pretty intense
There was a problem hiding this comment.
To me it looks like he's removing the following chars form the key -, _, ., !, ~, [, ], *, ', (, ), /, ,, ;, :, -, %, +, .. Two of them, namely ] and - need escaping with \.
|
Nice to see some feedback on this I've cleaned up this old code and reworked the key generation function to better match the onlyoffice recommandations. I also added support for JWT auth as this is now enabled by default on onlyoffice (this only works on secure connections as we're using the WebCrypto API, but you can still disable JWT auth on the documentserver and leave the config field blank) |
|
Any idea when this PR will be merged? Can't wait to use Onlyoffice with filebrowser |
|
Look forward to this feature 👍🏻 |
|
Thank your for taking the time add this, very nice integration. |
o1egl
force-pushed
the
master
branch
2 times, most recently
from
813c2e9
to
66dfbb3
Compare
|
Hello! |
|
The latest version of FileRun has built-in support for OnlyOffice and a bunch more plugins (including Google Docs, Office 365 for Web, etc) from what I've seen |
According to information from the official website FileRun: And not open-source. |
|
It may be that filebrowser is supposed to be more suckless, where you just merge your own patches to customize for yourself |
|
Maybe use OnlyOffice in view mode only, is for this requires filerun? |
|
Is there a timeline for this, I would love to see this become an option. |
|
This integration is very valuable, hope it will be merged soon. |
|
This very useful PR is open for such a long time already. When will it be merged? |
|
yall do realize that you can just use drosoCode's fork if you want the feature rn right? |
Not the point. |
|
I'd also love to see this merged. There aren't many lightweight alternatives to FileBrowser that have an OnlyOffice integration. NextCloud is overkill for my purposes and Filestash has a different focus. |
|
@o1egl and @Rushmore75 can you please have a look at this? Thank you. |
| } | ||
| }; | ||
| if(onlyOffice.jwtSecret != "") { |
There was a problem hiding this comment.
Looks like a security breach. What is the purpose of this secret? Security tokens should never be exposed to the clients.
| Date.parse(this.req.modified).valueOf() | ||
| + url | ||
| .encodePath(this.req.path.split('/').reverse().join('')) | ||
| .replaceAll(/[!~[\]*'()/,;:\-%+. ]/g, "") | ||
| ).substring(0, 20); |
There was a problem hiding this comment.
How about using a hashing algorithm like md5 instead of performing this magical process?
| return http.StatusInternalServerError, err | ||
| } | ||
|
|
||
| if data.Status == 2 || data.Status == 6 { |
There was a problem hiding this comment.
Please use meaningful constants instead of magic numbers
|
oh wow, I was looking for exactly this feature and stumbled on this ticket today. @drosoCode , any chance you could follow up on @o1egl 's review? :) |
|
Sure, I'll make the required changes as soon as I have enough time to work on it |
|
Any news? Would be cool to get this merged soon :D |
|
Hi everyone, decided to try addressing the comments on this in order to get some traction again. I've created a new pull request here: I rebased @drosoCode 's contributions against the latest master branch and created a new commit on top of it to address the pending comments above. @drosoCode @o1egl , would you be able to review? |
|
Hi, |
Description
Add onlyoffice editor, to be able to edit word, excel and powerpoint docs.
OnlyOffice Document Server is required, the URL to this server can be configured in the General Settings.
To run the document server:
docker run -d -p 8081:80 onlyoffice/documentserverImage:
Related issues: