Fix shadow bug on Firefox #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
box-shadow: 0 0 0 0; leaves a slight edge on Firefox. box-shadow does accept `none`, which works as expected.
|
before after |
|
Thanks @princemaple! I have already found that bug but I didn't really know where the problem was 😅 Thanks! |
hacdias
added a commit
that referenced
this pull request
May 11, 2019
Fix shadow bug on Firefox Former-commit-id: 41c849c89ae354e6a9674d9e3b572e70ba4e223b [formerly 8885e3c0a3f9be10f59c3cfabf2eda032c7b8c17] [formerly 3b6c6e8ad1e1e5805af0bbdfe9690486efa322b9 [formerly b9e6887]] Former-commit-id: a5a61f06de8cd9cceb223ac1fcfe2026f8afb0e1 [formerly 731a2f87cd37a5532a6309e59429650cfc8777fb] Former-commit-id: 41536048386008941403f6094e753adc22b542a6
hacdias
pushed a commit
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
box-shadow: 0 0 0 0; leaves a slight edge on Firefox.
box-shadow does accept
none, which works as expected.