Add a healthcheck script that works with a dynamic port. #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the reason for changing the port inside a docker container? |
I have multiple containers within the same network namespace in podman so that they can all resolve each other via DNS, but this means they also share a port namespace and cannot all listen on the same ports. Port mapping to a different host port is orthogonal, and so I just change the ports my container software listens on should they collide instead of assuming port 80. For example, in my use case, port 80 in that namespace is being listened on by a reverse proxy. |
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Jul 31, 2023
…owser#2510) feat: add dockerfile change (cherry picked from commit ff4375c)
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Jul 31, 2023
…owser#2510) (cherry picked from commit ff4375c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the docker healthcheck command to run an external script that supports a custom port from the
.filebrowser.jsonconfig file.