Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Follow $FB_PORT when set #2812

Merged
merged 1 commit into from Nov 8, 2023
Merged

fix: Follow $FB_PORT when set #2812

merged 1 commit into from Nov 8, 2023

Conversation

efrecon
Copy link
Contributor

@efrecon efrecon commented Nov 6, 2023

When the FB_PORT environment variable is set, respect its value. Otherwise, pick the port from the configuration.

Description

When run as a Docker container, the healthcheck will fail if the server port is set using the FB_PORT environment variable. This provides a fix by respecting the value of that variable in the healthcheck implementation, otherwise defaulting to the one from the configuration file.

馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

When the `FB_PORT` environment variable is set, respect its value. Otherwise, pick the port from the configuration.
@efrecon efrecon requested a review from o1egl as a code owner November 6, 2023 18:05
@efrecon efrecon changed the title Follow $FB_PORT when set fix: Follow $FB_PORT when set Nov 6, 2023
@o1egl o1egl merged commit d59ad59 into filebrowser:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants