Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language names from translations #3140

Merged
merged 2 commits into from Apr 24, 2024
Merged

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Apr 21, 2024

Description

Currently the language names are stored in the translations for each language. But they don't need to be translated by themselves. This is confusing when I see the keys in the Transfinex.
The PR simplifies code, reduce confusion and slightly makes it faster.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • AVOID breaking the continuous integration build.

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
@stokito stokito requested a review from o1egl as a code owner April 21, 2024 11:09
@o1egl o1egl merged commit 0e0b0c8 into filebrowser:master Apr 24, 2024
7 of 8 checks passed
@stokito stokito deleted the lang branch April 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants