Snap Deals draft #146
Merged
Snap Deals draft #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
requested review from
arajasek,
dignifiedquire,
jennijuju,
momack2 and
whyrusleeping
as code owners
Kubuxu
force-pushed
the
non-interactive
branch
3 times, most recently
from
4a0bd22
to
fdf9bf7
Compare
nicola
reviewed
Aug 24, 2021
nicola
reviewed
Aug 24, 2021
nicola
reviewed
Aug 24, 2021
nicola
reviewed
Aug 24, 2021
nicola
reviewed
Aug 24, 2021
nicola
reviewed
Aug 24, 2021
kaitlin-beegle
approved these changes
Sep 11, 2021
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
non-interactive
branch
from
b45a69c
to
e2f72f0
Compare
|
I applied @nicola 's feedback. Feel free to merge to assign FIP number. Additional rounds of changes will happen after that. |
arajasek
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #145 for discussion