FRC-0042: expand rejection sampling to numbers < 256 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
requested review from
momack2,
arajasek,
jennijuju and
kaitlin-beegle
as code owners
6 tasks
|
Can we increase this even more? I.e., reserve 0x7FFFFFFF? (or even just 0xFFFF). There's really no reason to go small here. |
jennijuju
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the range of method numbers excluded by the rejection sampling mechanism to 256. This removes the possibility of collision with any existing built-in actor method number, and leaves a decent range for new actors to use for internal dispatch or other conventions.
This idea is due to @Kubuxu.