FIP-0091: Add support for legacy Ethereum transactions #995

aarshkshah1992 · 2024-04-17T15:43:23Z

This FIP adds support for legacy Homestead Ethereum transactions to Filecoin.

Note that only legacy Ethereum transactions with the following parameters will be supported.

type LegacyEthTx struct {
	Nonce int  
	To *EthAddress
	Value big.Int
	GasPrice big.Int
	GasLimit int  
	Input []byte  
	V big.Int 
	R big.Int 
	S big.Int
}

As legacy transactions do not have a ChainID, the same signed contract creation transaction can be used to create the contract on multiple chains and ensure that the address of the contract remains the same on all chains. There are some legacy contracts whose users need support for such chain agnostic transactions and contract creation.

Support for EIP-155 and EIP-2930 transactions is deferred to future FIPs.

Discussion at #962.

Stebalien

This fip is really clear and well written.

FIPS/fip-00xx.md

Stebalien · 2024-04-18T03:08:05Z

FIPS/fip-00xx.md

+
+Given that the current signature verification implementation for the delegated signature type(which is the signature type that will be used for legacy ETH transactions in addition to EIP1599 transactions) only recognizes `V` values of 0 or 1, it is necessary to adjust the `V` value in the signature of legacy transactions by subtracting 27. This adjustment must be made prior to the authentication and verification of the message's signature, as well as before extracting the public key and sender's address from the legacy transaction's signature.
+
+Note that this is only a temporary transformation for the purpose of a validating the signature of a legacy transaction and for extracting the public key of the sender from the signature. The `V` value that gets persisted in the chain state for the legacy transaction will be the original `V` value set on the legacy transaction by the user.


You know... Can we use V to indicate the version (it can only be one of two values right now)?

The problem is that the V value is signed by the user. So we can't persist the mutated V value to the chain state.

@Stebalien Aha wait, do you mean that if V is 27 or 28, we just assume it's a legacy transaction ?

Well,

We record a V in the signature.

There's a V' stored/signed in the transaction.

But they don't have to be the same as long as we can derive one from the other.

But... yeah, we could also say 27/28 means "legacy" (I think). I don't feel strongly about this and you're now more familiar with the code than I am, but I'm bringing this up in case it ends up being a simpler/cleaner solution.

I think we should go ahead and stick with using the marker byte in the signature to detect transaction types as it is more forward compatible and also makes it easy to add support for more transaction types down the line.

Stebalien · 2024-04-18T03:10:09Z

FIPS/fip-00xx.md

+
+However, legacy Ethereum transactions only have a single `GasPrice` parameter, which specifies the gas price a sender is willing to pay per unit of gas to process the transaction. 
+
+Under the FVM fee market framework, when processing legacy transactions, `GasPrice` is adapted to simultaneously fulfill the roles of both `GasFeeCap` and `GasPremium`. In this adaptation, both `GasFeeCap` and `GasPremium` are set equal to `GasPrice`. Initially, the base fee is subtracted, and any remaining attoFIL from the `GasPrice`, after this deduction, is allocated entirely as a priority fee to the miner. This arrangement ensures that the total fee (base fee plus priority fee) paid by the user for a legacy transaction does not surpass the `GasPrice` set by the user on the legacy ETH transaction.


Hm... This strongly incentivizes SPs to hoard these transactions until the gas fee drops. Not much we can do about that, I guess...

The same thing would happen in Ethereum as well for legacy transactions.

Yep. But it may be worth noting it.

Explicitly noted this.

Schwartz10 · 2024-04-18T19:44:16Z

Hey thanks for putting this together @aarshkshah1992 - one additional thing to note wrt "Change Motivation" - we also just generically get a lot of user's complaining about wallets not working to do simple sends of FIL (even outside of the GLIF UI). For instance, see this email from last night:

Sending FIL natively from Coinbase wallet (and several others like Trust, Phantom) should "just work". This doesn't seem related to being able to deploy smart contracts, but it's still quite important to fix because many user's are stuck with their FIL in wallets that throw this same error. Their only choice right now is to import their same private keys / seed phrases into a new wallet, which is not a safe practice. In an ideal world no wallet provider would send legacy txns, but that's just not the case.

jsoares

Very well drafted -- I wasn't terribly familiar with the details of eth transaction types but this makes it super clear. Nothing to point out from an editorial perspective.

raulk

Excellent write-up! LGTM, just barring some typos and getting 1599 and 1559 mixed up (recommend find & replace all).

FIPS/fip-00xx.md

raulk · 2024-04-17T15:49:25Z

FIPS/fip-00xx.md

+The Filecoin network already supports EIP-1599 transactions. These transactions have a designated transaction type of `0x02` and have the following parameters:
+
+```
+type EIP1599Tx struct {


gofmtting would be great!

FIPS/fip-00xx.md

raulk · 2024-04-17T16:02:22Z

FIPS/fip-00xx.md

+3. Distinguish the transaction type based on the signature length:
+   - If the signature is 66 bytes long and starts with `0x80`, it is translated to a legacy ETH transaction.
+   - If the signature is 65 bytes long, it corresponds to an EIP-1559 transaction.
+4. Validate the transaction parameters and signature.


It's obvious, but we'd also strip the leading 0x80 byte from the signature of a legacy tx.

@raulk You mean before verifying the signature, right ? Yes, ofcourse.

But this leading marker byte will ofcourse make it's way to the chain state.

Explicitly noted this.

FIPS/fip-00xx.md

README.md

raulk

Excellent write-up! LGTM, just barring some typos and getting 1599 and 1559 mixed up (recommend find & replace all).

raulk

Excellent write-up! LGTM, just barring some typos and getting 1599 and 1559 mixed up (recommend find & replace all).

raulk

Excellent write-up! LGTM, just barring some typos and getting 1599 and 1559 mixed up (recommend find & replace all).

raulk · 2024-04-20T11:48:30Z

FIPS/fip-00xx.md

+
+## Specification
+
+Filecoin supports EIP-1559 transactions by converting them into standard Filecoin messages. These messages are distinguished by a unique "delegated" signature type, which encapsulates the original Ethereum transaction signature. The validation process for these messages involves:


(Peer review) We need a subsection on Eth JSON-RPC support. We should scope exactly which methods are affected and how. I think eth_sendRawTransaction, eth_getTransactionByHash, eth_getBlockBy* are all affected.

raulk · 2024-04-20T11:57:54Z

FIPS/fip-00xx.md

+
+Enabling support for legacy ETH transactions with this FIP allows for the straightforward deployment of these contracts on the Filecoin network by replaying the original, signed legacy contract deployment transactions on the Filecoin network.
+
+## Specification


(Peer review) Have you discarded the need for changes at the EVM runtime level? If so, may be worth stating that explicitly to aid implementers' understanding of scope.

Explicitly noted this.

Co-authored-by: raulk <raul@protocol.ai>

aarshkshah1992 · 2024-04-22T06:23:59Z

@Schwartz10 Thanks for pointing that out. I have added the point about wallet support for legacy transactions to the Change Motivation section

jennijuju · 2024-04-23T00:08:06Z

FIPS/fip-00xx.md

@@ -0,0 +1,165 @@
+---
+fip: "XXXX"


Assigning 0091

FIPS/fip-00xx.md

jennijuju · 2024-04-23T00:12:50Z

FIPS/fip-00xx.md

+}
+```
+
+The main distinction relevant to this FIP is that legacy transactions do not contain a `ChainID` and so the transactions are not scoped to a specific chain.  This allows replaying the same signed contract creation transaction across multiple chains for deploying a contract and also enables the contract to have the same address across chains.


This allows replaying the same signed contract creation transaction across multiple chains

Just a question, is the risk only exposed to contract tx, but not to pure value transfer across wallet accounts (eth accounts) as well? (I'm curious how those two type of tx are differentiated

You can do value transfers with this as well using legacy transactions i.e. you can use the same signed value transfer message across networks for value transfer (the nonces, state etc should align for the transaction to be considered valid).

The way it is written right now seems excluded this use case

FIPS/fip-00xx.md

Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

jennijuju · 2024-04-26T16:54:09Z

FIPS/fip-0091.md

+title: Add support for legacy Homstead Ethereum Trasnactions 
+author: Aarsh (@DharmaBum) 
+discussions-to: https://github.com/filecoin-project/FIPs/discussions/962
+status: Accepted


DO NOT MERGE. Please don’t change main key info w/o requesting fip editors’s re-review after their approvals.
This FIP is not Accepted. Fip editors’ approval on this PR only suggests the FIP draft is content ready to be merged to FIP repo. It doesn’t imply FIP’s readiness for the network. FIP must go through core dev and community’s review, and a last call period before it is accepted.

@jennijuju Apologies, I thought having 2 approvals meant that the FIP is now accepted. I have changed it back to Draft status.

All good! Now you are a fip process master 😆😆

aarshkshah1992 added 2 commits April 17, 2024 21:00

add support for legacy ETH transactions

eb45d98

add support for legacy Homestead Ethereum transactions

4812c36

aarshkshah1992 requested review from momack2, arajasek, jennijuju, kaitlin-beegle, anorth, raulk, jsoares and TippyFlitsUK as code owners April 17, 2024 15:43

aarshkshah1992 added 2 commits April 17, 2024 21:15

revert change

354ef80

revert change

37a98fc

Stebalien reviewed Apr 18, 2024

View reviewed changes

update as per review

2e196bc

jennijuju mentioned this pull request Apr 19, 2024

Add eth legacy tx filecoin-project/lotus#11906

Closed

jsoares approved these changes Apr 19, 2024

View reviewed changes

raulk approved these changes Apr 19, 2024

View reviewed changes

raulk reviewed Apr 20, 2024

View reviewed changes

aarshkshah1992 and others added 2 commits April 22, 2024 10:06

Apply suggestions from code review

35e5b9a

Co-authored-by: raulk <raul@protocol.ai>

address review on the FIP

67c3d66

add integration branch

2327db9

jennijuju reviewed Apr 23, 2024

View reviewed changes

FIPS/fip-00xx.md Outdated

@@ -0,0 +1,165 @@

---

fip: "XXXX"

Copy link

Member

jennijuju Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning 0091

jennijuju reviewed Apr 23, 2024

View reviewed changes

FIPS/fip-00xx.md Outdated Show resolved Hide resolved

jennijuju reviewed Apr 23, 2024

View reviewed changes

FIPS/fip-00xx.md Outdated Show resolved Hide resolved

jennijuju approved these changes Apr 23, 2024

View reviewed changes

jennijuju changed the title ~~FIP-XXXX: Add support for legacy Ethereum transactions~~ FIP-0091: Add support for legacy Ethereum transactions Apr 23, 2024

aarshkshah1992 and others added 5 commits April 23, 2024 10:49

Apply suggestions from code review

4551c0d

Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com>

Merge branch 'master' into aarshkshah1992/fip/add-support-legacy-eth-tx

50e990e

Rename fip-00xx.md to fip-0091.md

2ab1ff2

Update fip-0091.md

d3969cb

Update fip-0091.md

10d0994

aarshkshah1992 mentioned this pull request Apr 26, 2024

feat: ETH compatibility in Filecoin : Support legacy Homestead Ethereum transactions and legacy EIP-155 transactions in Filecoin filecoin-project/lotus#11930

Closed

8 tasks

jennijuju requested changes Apr 26, 2024

View reviewed changes

aarshkshah1992 added 2 commits April 27, 2024 22:22

Update fip-0091.md

5afb939

Update README.md

75756f4

jennijuju approved these changes Apr 27, 2024

View reviewed changes

jennijuju merged commit 047b8df into master Apr 27, 2024
1 check passed

jennijuju deleted the aarshkshah1992/fip/add-support-legacy-eth-tx branch April 27, 2024 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIP-0091: Add support for legacy Ethereum transactions #995

FIP-0091: Add support for legacy Ethereum transactions #995

aarshkshah1992 commented Apr 17, 2024

Stebalien left a comment

Stebalien Apr 18, 2024

aarshkshah1992 Apr 18, 2024

aarshkshah1992 Apr 18, 2024

Stebalien Apr 18, 2024

aarshkshah1992 Apr 22, 2024

Stebalien Apr 18, 2024

aarshkshah1992 Apr 18, 2024

Stebalien Apr 18, 2024

aarshkshah1992 Apr 22, 2024 •

edited

Schwartz10 commented Apr 18, 2024 •

edited

jsoares left a comment

raulk left a comment

raulk Apr 17, 2024

aarshkshah1992 Apr 22, 2024

raulk Apr 17, 2024

aarshkshah1992 Apr 20, 2024

aarshkshah1992 Apr 20, 2024

aarshkshah1992 Apr 22, 2024

raulk left a comment

raulk left a comment

raulk left a comment

raulk Apr 20, 2024 •

edited

raulk Apr 20, 2024 •

edited

aarshkshah1992 Apr 22, 2024

aarshkshah1992 commented Apr 22, 2024

jennijuju Apr 23, 2024

jennijuju Apr 23, 2024

aarshkshah1992 Apr 26, 2024

jennijuju Apr 27, 2024

jennijuju Apr 26, 2024 •

edited

aarshkshah1992 Apr 27, 2024

jennijuju Apr 27, 2024


		Given that the current signature verification implementation for the delegated signature type(which is the signature type that will be used for legacy ETH transactions in addition to EIP1599 transactions) only recognizes `V` values of 0 or 1, it is necessary to adjust the `V` value in the signature of legacy transactions by subtracting 27. This adjustment must be made prior to the authentication and verification of the message's signature, as well as before extracting the public key and sender's address from the legacy transaction's signature.

		Note that this is only a temporary transformation for the purpose of a validating the signature of a legacy transaction and for extracting the public key of the sender from the signature. The `V` value that gets persisted in the chain state for the legacy transaction will be the original `V` value set on the legacy transaction by the user.


		However, legacy Ethereum transactions only have a single `GasPrice` parameter, which specifies the gas price a sender is willing to pay per unit of gas to process the transaction.

		Under the FVM fee market framework, when processing legacy transactions, `GasPrice` is adapted to simultaneously fulfill the roles of both `GasFeeCap` and `GasPremium`. In this adaptation, both `GasFeeCap` and `GasPremium` are set equal to `GasPrice`. Initially, the base fee is subtracted, and any remaining attoFIL from the `GasPrice`, after this deduction, is allocated entirely as a priority fee to the miner. This arrangement ensures that the total fee (base fee plus priority fee) paid by the user for a legacy transaction does not surpass the `GasPrice` set by the user on the legacy ETH transaction.


		## Specification

		Filecoin supports EIP-1559 transactions by converting them into standard Filecoin messages. These messages are distinguished by a unique "delegated" signature type, which encapsulates the original Ethereum transaction signature. The validation process for these messages involves:


		Enabling support for legacy ETH transactions with this FIP allows for the straightforward deployment of these contracts on the Filecoin network by replaying the original, signed legacy contract deployment transactions on the Filecoin network.

		## Specification

FIP-0091: Add support for legacy Ethereum transactions #995

FIP-0091: Add support for legacy Ethereum transactions #995

Conversation

aarshkshah1992 commented Apr 17, 2024

Stebalien left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aarshkshah1992 Apr 22, 2024 • edited

Choose a reason for hiding this comment

Schwartz10 commented Apr 18, 2024 • edited

jsoares left a comment

Choose a reason for hiding this comment

raulk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raulk left a comment

Choose a reason for hiding this comment

raulk left a comment

Choose a reason for hiding this comment

raulk left a comment

Choose a reason for hiding this comment

raulk Apr 20, 2024 • edited

Choose a reason for hiding this comment

raulk Apr 20, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aarshkshah1992 commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jennijuju Apr 26, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aarshkshah1992 Apr 22, 2024 •

edited

Schwartz10 commented Apr 18, 2024 •

edited

raulk Apr 20, 2024 •

edited

raulk Apr 20, 2024 •

edited

jennijuju Apr 26, 2024 •

edited