feat: implement GPU FFT & Multiexp #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyvank
force-pushed
the
gpu
branch
2 times, most recently
from
183ebdb
to
2189af1
Compare
|
@dignifiedquire Made some changes. Can you review again? |
dignifiedquire
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Looking good, left one more comment.
Note: as we use a nightly toolchain for our building, we are somewhat blocked on cogciprocate/ocl#163 to enable the gpu feature by default, but that will hopefully be solved soon.
dignifiedquire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR from @finalitylabs adds GPU accelerated versions of the Fast-Fourier-Transform and Multi-Exponentiation (For Bls12-381 engine) algorithms to the great Bellman library :) The
oclfeature is turned on by default and can be disabled.Let us know if any changes are needed before merging. @dignifiedquire
@nginnever, @keyvank