Bump ff, group to 0.13 and pairing to 0.23 #54

huitseeker · 2023-04-11T16:35:26Z

Interesting points:

constants used in imp PrimeField for Scalar: https://github.com/zkcrypto/bls12_381/blob/main/src/scalar.rs
implementations of sqrt_ratio: following the trend of the unimplemented! sqrt,

/cc @vmx

vmx

Just minor things.

src/fp2.rs

src/scalar.rs

src/macros.rs

rust-toolchain

vmx reviewed Apr 12, 2023

View reviewed changes

src/fp2.rs Outdated Show resolved Hide resolved

src/scalar.rs Show resolved Hide resolved

src/macros.rs Outdated Show resolved Hide resolved

src/macros.rs Outdated Show resolved Hide resolved

src/macros.rs Outdated Show resolved Hide resolved

rust-toolchain Outdated Show resolved Hide resolved

huitseeker force-pushed the WIP-0.13 branch from ddcb2c3 to 185cf99 Compare April 12, 2023 15:30

huitseeker added 3 commits April 13, 2023 08:49

Bump ff, group to 0.13 and pairing to 0.23

a2db9ba

fix: make clippy happy

5f80196

address review comments

d974250

huitseeker force-pushed the WIP-0.13 branch from 185cf99 to d974250 Compare April 13, 2023 13:03

vmx approved these changes Apr 14, 2023

View reviewed changes

vmx merged commit 285275a into filecoin-project:master Apr 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump ff, group to 0.13 and pairing to 0.23 #54

Bump ff, group to 0.13 and pairing to 0.23 #54

huitseeker commented Apr 11, 2023

vmx left a comment

Bump ff, group to 0.13 and pairing to 0.23 #54

Bump ff, group to 0.13 and pairing to 0.23 #54

Conversation

huitseeker commented Apr 11, 2023

vmx left a comment

Choose a reason for hiding this comment