Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove boost-gfm and go-data-transfer #1740

Merged
merged 39 commits into from
Feb 19, 2024
Merged

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Oct 9, 2023

This PR will make the following changes:

  1. Remove go-fil-markets and boost-gfm as direct dependency for Boost
  2. Remove go-data-transfer as direct depdency for Boost
  3. Create new storageAsk table in SQL and replace AskGetter
  4. Remove legacy storage provider
  5. Remove legacy retrievals provider
  6. Remove goLegs voucher handling from Graphsync
  7. Handle query ask within Boost provider
  8. Clean up legacy config

TODO:

  • Fix the circular dependency
  • Refactor Graphsync unit tests to use boost client or remove these tests
  • Fix Graphsync unknown status code error
  • Verify all itests are passing
  • Ask Rod to recheck verify Graphsync tests
  • Fix any other issues
  • ReCheck what interfaces should be part of Boost{}
  • Test in devnet
  • clean up config
  • clean up legacy storage UI and resolver

TODO: (Out of the scope of this PR):

  • Cleanup the local go-data-transfer
  • Explore compatibility with go-data-transfer/v2
  • clean up unused legacy storage types and legacy retrieval types

@LexLuthr LexLuthr added this to the Boost v2 stability milestone Oct 24, 2023
@nonsense nonsense removed this from the Boost v2 stability milestone Oct 26, 2023
@LexLuthr
Copy link
Collaborator Author

LexLuthr commented Dec 19, 2023

Testing

Devnet

  • Make a deal
Screenshot 2023-12-19 at 6 05 53 PM
  • Retrieve
Screenshot 2023-12-19 at 6 06 21 PM
  • Make multiple deals
  • Storage and funds page
Screenshot 2023-12-19 at 6 23 04 PM Screenshot 2023-12-19 at 6 23 10 PM
  • Explore piece-doctor
Screenshot 2023-12-19 at 6 06 00 PM Screenshot 2023-12-19 at 6 06 04 PM
  • Set ask
root@8d742ac45d12:/app# boost provider storage-ask t01000
Ask: t01000
Price per GiB: 0.00000000005 FIL
Verified Price per GiB: 0.000000000005 FIL
Max Piece size: 32 GiB
Min Piece size: 1 KiB ----> Changed
  • Get ask
root@8d742ac45d12:/app# boost provider storage-ask t01000
Ask: t01000
Price per GiB: 0.00000000005 FIL
Verified Price per GiB: 0.000000000005 FIL
Max Piece size: 32 GiB
Min Piece size: 1 KiB
  • Get Ask from Lotus
root@da6aaeb9d5db:/app# lotus client query-ask t01000
Ask: t01000
Price per GiB: 0.00000000005 FIL
Verified Price per GiB: 0.000000000005 FIL
Max Piece size: 32 GiB
Min Piece size: 1 KiB
  • Legacy deal rejection
root@da6aaeb9d5db:/app# lotus client get-deal bafyreiapdk23crmzrg3vqwtzowhkfdj7m6oc4tj6fx3ufo3lmqe7gyylsy

  "DealInfo: ": {
    "ProposalCid": {
      "/": "bafyreiapdk23crmzrg3vqwtzowhkfdj7m6oc4tj6fx3ufo3lmqe7gyylsy"
    },
    "State": 26,
    "Message": "unexpected deal status while waiting for data request: 2 (StorageDealProposalRejected). Provider message: deal proposals made over the legacy /fil/storage/mk/1.1.1 protocol are deprecated - please use the /fil/storage/mk/1.2.1 deal proposal protocol",

Sofiaminer

  • Make a new deal
  • Deal filters
  • Legacy deal page
  • Legacy deal rejection
  • Legacy storage
  • Set ask
  • Get ask
  • IPNI Ads and sync
  • Multiminer retrieval

Copy link
Collaborator

@ischasny ischasny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting it over the line 🙏

@LexLuthr
Copy link
Collaborator Author

LexLuthr commented Dec 20, 2023

SofiaMiner testing:

  • Fix Ask not getting stored on DB

@LexLuthr LexLuthr linked an issue Dec 22, 2023 that may be closed by this pull request
@LexLuthr LexLuthr merged commit 3b49cd1 into main Feb 19, 2024
19 checks passed
@LexLuthr LexLuthr deleted the remove-legacy-markets branch February 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove go-fil-markets / go-data-transfer dependencies
5 participants