Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LID clean up #1881

Merged
merged 13 commits into from
Mar 6, 2024
Merged

feat: LID clean up #1881

merged 13 commits into from
Mar 6, 2024

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Feb 28, 2024

Fixes #1709

Implementation Details:

  1. The process runs every 6 hours
  2. It removes Completed/Slashed Boost deals, Completed Legacy Deals and TermMax reached Direct deals from LID
  3. It also removed any dangling deals from LID which are not associated with any deals in SQL DB but are attributed to the miner ID
  • Account for FIP-45 as deal end epoch is no longer reliable

@LexLuthr
Copy link
Collaborator Author

@nonsense I have added some extra layering to check miner ID before deleting a deal. This is causing issue with Cassandra as it it not a primary key. I could try to figure out a workaround but I wanted to get your opinion if we need to worry about this corner case or am I thinking too much here?

cmd/boostd/piecedir.go Outdated Show resolved Hide resolved
cmd/boostd/piecedir.go Outdated Show resolved Hide resolved
cmd/boostd/piecedir.go Outdated Show resolved Hide resolved
extern/boostd-data/ldb/service.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Show resolved Hide resolved
lib/pdcleaner/pdcleaner_test.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from masih February 29, 2024 06:42
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
node/config/types.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from masih February 29, 2024 21:49
@LexLuthr LexLuthr requested a review from rvagg March 4, 2024 15:10
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
lib/pdcleaner/pdcleaner.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr merged commit fa61997 into main Mar 6, 2024
20 checks passed
@LexLuthr LexLuthr deleted the feat/lid-cleanup branch March 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Epic] LID cleanup
3 participants