Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

power actor tests part 3 #282

Merged
merged 2 commits into from
Apr 27, 2022
Merged

power actor tests part 3 #282

merged 2 commits into from
Apr 27, 2022

Conversation

LesnyRumcajs
Copy link
Contributor

Implemented tests from here.

  • enroll_cron_epoch_multiple_events
  • enroll_cron_epoch_before_current_epoch
  • enroll_cron_epoch_given_negative_epoch_should_fail

ZenGround0
ZenGround0 reviewed Apr 27, 2022
View reviewed changes
actors/power/tests/power_actor_tests.rs Outdated Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Outdated Show resolved Hide resolved
ZenGround0
ZenGround0 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are suggestions apart from moving methods to harness and adding rt.verify() to the enroll cron harness method. After those two changes and whatever other suggested changes you implement feel free to merge.

actors/power/tests/power_actor_tests.rs Outdated Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Outdated Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Show resolved Hide resolved
actors/power/tests/power_actor_tests.rs Outdated Show resolved Hide resolved
@LesnyRumcajs
Copy link
Contributor Author

@ZenGround0 thanks for the detailed review!

@LesnyRumcajs LesnyRumcajs enabled auto-merge (squash) April 27, 2022 15:31
@LesnyRumcajs LesnyRumcajs merged commit cf69be5 into master Apr 27, 2022
@LesnyRumcajs LesnyRumcajs deleted the power-actor-tests-part-3 branch April 27, 2022 15:37
@Stebalien Stebalien mentioned this pull request Aug 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LesnyRumcajs @ZenGround0