Implements datacap token actor #513
Conversation
anorth
force-pushed
the
anorth/datacap-token
branch
4 times, most recently
from
3c4f9d6
to
3582f12
Compare
| pub fn check_state_invariants<BS: Blockstore>( | ||
| _state: &State, | ||
| _store: &BS, | ||
| ) -> (StateSummary, MessageAccumulator) { |
There was a problem hiding this comment.
Maybe the token library can provide a generic state invariant check?
anorth
force-pushed
the
anorth/datacap-token
branch
3 times, most recently
from
83a6b43
to
d07b601
Compare
|
@alexytsu I can't request review from you, but would appreciate you taking a look too |
.github/workflows/ci.yml
Outdated
| @@ -2,6 +2,9 @@ name: Continuous integration | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
Do we want to introduce commits from master to the integration branch like this? I would think we add these commits in separate PRs, or if we can avoid it not at all.
There was a problem hiding this comment.
Sorry, oversight. I should have rebased the integration branch and then this first
| use fvm_shared::bigint::{bigint_ser, BigInt}; | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize_tuple, Deserialize_tuple)] | ||
| pub struct AllowanceParams { |
There was a problem hiding this comment.
Have we considered moving the generalized token type parameters into the token library?
There was a problem hiding this comment.
Yes, they're not quite ready yet
| pub mod testing; | ||
| mod types; | ||
|
|
||
| /// TODO: |
There was a problem hiding this comment.
Are we keeping these on the integration branch or trying to remove all TODOs each PR?
There was a problem hiding this comment.
Ok to keep a few on integration branch
Still some development going, I reckon wait til next week for that. |
anorth
force-pushed
the
anorth/datacap-token
branch
from
d07b601
to
1014d9d
Compare
|
Build failure addressed by implementing the token library's Messaging trait in terms of the Runtime. It's a bit messy due to mismatches there, would be easier if the Runtime was moved closer to the real syscall API. |
anorth
force-pushed
the
anorth/datacap-token
branch
from
1014d9d
to
e61e26e
Compare
|
Now pinned to a commit on |
| fn actor_id(&self) -> ActorID { | ||
| // The Runtime unhelpfully wraps caller in an ID, while the Messaging trait | ||
| // is closer to the syscall interface. | ||
| self.rt.message().caller().id().unwrap() |
There was a problem hiding this comment.
This should be self.rt.message().receiver().id().unwrap(), it is the ID of this actor itself (used to populate receiver hooks for the from field during minting)
Implements a standalone datacap fungible token actor, using the Helix fungible token actor library in development for filecoin-project/FIPs#407
Part of filecoin-project/FIPs#313. Not yet integrated with anything. I haven't written tests yet as we're merging to a development branch with priority on ensuring the end-to-end hookup is correct.
This is ready for review, with following caveats:
Closes #522