Datacap integration tests #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
force-pushed
the
test/datacap-token-itests
branch
2 times, most recently
from
29ddfbb
to
bf2892e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 87.86% 86.73% -1.14%
==========================================
Files 95 95
Lines 19796 19916 +120
==========================================
- Hits 17394 17274 -120
- Misses 2402 2642 +240
|
anorth
approved these changes
Oct 6, 2022
| ) | ||
| .unwrap(), | ||
| }; | ||
| let clone_params = |x: &TransferFromParams| -> TransferFromParams { |
There was a problem hiding this comment.
Do you wanna file an issue in the token lib to derive Clone for all these types?
* Propagate errors from universal receiver hook * Test hitting many error cases and passing
ZenGround0
force-pushed
the
test/datacap-token-itests
branch
from
ceb33e2
to
6826409
Compare
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
* Datacap Integration Test * Propagate errors from universal receiver hook Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise the datacap actor directly and exercise error paths
Discovered the missing propagation of universal receiver hook errors back to data cap and modified the messenger trait implementation accordingly