New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage market protocols versions 1.1.0 #505

Merged

Alexey-N-Chernyshov merged 16 commits into master from feature/check-signature-on-storage-deal-status

Dec 4, 2021

Contributor

Alexey-N-Chernyshov commented Nov 16, 2021

deal status request signature check

Signed-off-by: Alexey-N-Chernyshov alexey.n.chernyshov@gmail.com

Description of the Change

Deal protocols v1.1.1.
Request deal status check.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]


          deal protocols versions 1.1.1 added

d604f2c

deal status request signature check

Signed-off-by: Alexey-N-Chernyshov <alexey.n.chernyshov@gmail.com>

codecov bot commented Nov 16, 2021 •

edited

Codecov Report

Merging #505 (b964107) into master (e59a5b3) will increase coverage by 0.23%.
The diff coverage is 73.40%.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   46.38%   46.61%   +0.23%     
==========================================
  Files         680      681       +1     
  Lines       30255    30518     +263     
  Branches    16759    16922     +163     
==========================================
+ Hits        14034    14227     +193     
- Misses      12182    12190       +8     
- Partials     4039     4101      +62

Impacted Files	Coverage Δ
core/api/full_node/node_api.hpp	`97.82% <ø> (ø)`
core/api/rpc/json.hpp	`12.56% <0.00%> (ø)`
core/api/storage_miner/storage_api.cpp	`0.00% <0.00%> (ø)`
core/api/storage_miner/storage_api.hpp	`0.00% <ø> (ø)`
...storage/client/impl/storage_market_client_impl.hpp	`28.57% <ø> (ø)`
...e/markets/storage/client/storage_market_client.hpp	`100.00% <ø> (ø)`
core/markets/storage/provider/provider.hpp	`100.00% <ø> (ø)`
...pes/market/deal_info_manager/deal_info_manager.hpp	`50.00% <ø> (ø)`
...re/markets/storage/provider/impl/provider_impl.hpp	`36.84% <35.29%> (-13.16%)`	⬇️
core/markets/storage/provider/impl/stored_ask.cpp	`71.21% <66.66%> (+0.44%)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcc3bb...b964107. Read the comment docs.

Alexey-N-Chernyshov requested a review from turuslan

November 17, 2021 06:57

Alexey-N-Chernyshov marked this pull request as ready for review

November 17, 2021 06:57

Alexey-N-Chernyshov requested a review from wer1st

November 17, 2021 06:58

Contributor

turuslan commented Nov 17, 2021 •

edited

Need to add Named encodable types for newer protocol versions. Also each handler must read/write old/new type.

lotus old: https://github.com/filecoin-project/go-fil-markets/blob/v1.13.1/storagemarket/migrations/migrations_cbor_gen.go#L1634-L1648
lotus new: https://github.com/filecoin-project/go-fil-markets/blob/v1.13.1/storagemarket/network/types_cbor_gen.go#L24-L51

c++ Named example: https://github.com/filecoin-project/cpp-filecoin/blob/master/core/markets/retrieval/protocols/retrieval_protocol.hpp#L30-L49

wer1st approved these changes

View reviewed changes

Alexey-N-Chernyshov added 2 commits

November 22, 2021 12:08


          Merge branch 'master' into feature/check-signature-on-storage-deal-st…

dd89f21

…atus


          named ask protocol

8a288f5

Signed-off-by: Alexey-N-Chernyshov <alexey.n.chernyshov@gmail.com>

Alexey-N-Chernyshov changed the title ~~deal protocols versions 1.1.1~~ deal protocols versions 1.1.0

Alexey-N-Chernyshov changed the title ~~deal protocols versions 1.1.0~~ [WiP] deal protocols versions 1.1.0

Alexey-N-Chernyshov force-pushed the feature/check-signature-on-storage-deal-status branch from 12e8987 to 4771392 Compare

November 25, 2021 09:48


          deal status protocol with OOP

6dd3c31

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

Alexey-N-Chernyshov force-pushed the feature/check-signature-on-storage-deal-status branch from 4771392 to 6dd3c31 Compare

November 25, 2021 09:57

Alexey-N-Chernyshov added 2 commits

November 25, 2021 18:05


          deal protocols versions 1.1.0 - WiP

43ef36d

Signed-off-by: Alexey-N-Chernyshov <alexey.n.chernyshov@gmail.com>


          deal status protocol

936285b

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

Alexey-N-Chernyshov force-pushed the feature/check-signature-on-storage-deal-status branch from 8f4c0a1 to b9ad8cf Compare

November 29, 2021 07:26


          fix stored_ask

1af24ca

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

Alexey-N-Chernyshov force-pushed the feature/check-signature-on-storage-deal-status branch from b9ad8cf to 1af24ca Compare

November 29, 2021 07:36


          Merge branch 'master' into feature/check-signature-on-storage-deal-st…

1bc4381

…atus

Alexey-N-Chernyshov changed the title ~~[WiP] deal protocols versions 1.1.0~~ Storage market protocols versions 1.1.0

Alexey-N-Chernyshov requested a review from wer1st

November 29, 2021 08:22

turuslan reviewed

View reviewed changes

core/markets/storage/ask_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/ask_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/ask_protocol.hpp Show resolved Hide resolved

core/markets/storage/ask_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/ask_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/mk_protocol.hpp Show resolved Hide resolved

core/markets/storage/mk_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/mk_protocol.hpp Show resolved Hide resolved

core/markets/storage/mk_protocol.hpp Outdated Show resolved Hide resolved

core/markets/storage/mk_protocol.hpp Outdated Show resolved Hide resolved

Alexey-N-Chernyshov added 5 commits

November 30, 2021 13:07


          add version display based on git describe command to command line, …

5a3de1f

…logs and API

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>


          remove map reencoding

9f6e387

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>


          Merge branch 'master' into feature/check-signature-on-storage-deal-st…

4bb8a68

…atus


          respect cbor map order

0519b3d

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>


          fixed old protocol and tests added

e42c8d0

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

turuslan reviewed

View reviewed changes

core/markets/storage/ask_protocol.hpp Outdated Show resolved Hide resolved


          pr fixes

2a15302

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

Alexey-N-Chernyshov requested a review from turuslan

December 1, 2021 13:52

turuslan reviewed

View reviewed changes

core/markets/storage/mk_protocol.hpp Outdated Show resolved Hide resolved

turuslan approved these changes

View reviewed changes


          Merge branch 'master' into feature/check-signature-on-storage-deal-st…

cec0f8f

…atus

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>

# Conflicts:
#	core/api/storage_miner/storage_api.hpp
#	core/markets/storage/deal_protocol.hpp
#	core/markets/storage/provider/impl/provider_impl.cpp
#	core/markets/storage/provider/impl/provider_impl.hpp
#	core/markets/storage/provider/impl/stored_ask.cpp
#	test/core/markets/storage/provider/stored_ask_test.cpp
#	test/core/markets/storage/storage_market_ask_test.cpp

Alexey-N-Chernyshov requested a review from ortyomka

December 2, 2021 09:01


          Merge branch 'master' into feature/check-signature-on-storage-deal-st…

b964107

…atus

Alexey-N-Chernyshov merged commit 0ec0155 into master

Alexey-N-Chernyshov deleted the feature/check-signature-on-storage-deal-status branch

December 4, 2021 07:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment