Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner deal fixes #541

Merged
merged 10 commits into from
Dec 1, 2021
Merged

Miner deal fixes #541

merged 10 commits into from
Dec 1, 2021

Conversation

ortyomka
Copy link
Contributor

Description of the Change

  • New Stored Ask (RAII)
  • Local JWT library
  • New method MarketListIncompleteDeals
  • Fix Fd behavior in Read Piece
  • Remove duplicate types

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@ortyomka ortyomka requested review from Elestrias, turuslan and Alexey-N-Chernyshov and removed request for Elestrias and turuslan November 30, 2021 06:50
Signed-off-by: ortyomka <iurin.art@gmail.com>
Signed-off-by: ortyomka <iurin.art@gmail.com>
core/miner/main/main.cpp Outdated Show resolved Hide resolved
Signed-off-by: ortyomka <iurin.art@gmail.com>
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #541 (058b5fe) into master (9dc996a) will decrease coverage by 0.05%.
The diff coverage is 31.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   46.44%   46.38%   -0.06%     
==========================================
  Files         679      680       +1     
  Lines       30185    30255      +70     
  Branches    16730    16759      +29     
==========================================
+ Hits        14018    14034      +16     
- Misses      12122    12182      +60     
+ Partials     4045     4039       -6     
Impacted Files Coverage Δ
core/api/rpc/json.hpp 12.56% <0.00%> (-0.28%) ⬇️
core/api/storage_miner/storage_api.cpp 0.00% <0.00%> (ø)
core/api/storage_miner/storage_api.hpp 0.00% <0.00%> (-5.72%) ⬇️
core/common/local_ip.hpp 0.00% <0.00%> (ø)
core/markets/storage/deal_protocol.hpp 77.77% <ø> (ø)
...re/markets/storage/provider/impl/provider_impl.hpp 50.00% <ø> (ø)
core/markets/storage/provider/provider.hpp 100.00% <ø> (ø)
core/miner/impl/miner_impl.cpp 0.00% <0.00%> (ø)
core/miner/main/main.cpp 0.00% <0.00%> (ø)
core/miner/miner.hpp 100.00% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc996a...058b5fe. Read the comment docs.

Signed-off-by: ortyomka <iurin.art@gmail.com>
Signed-off-by: ortyomka <iurin.art@gmail.com>
@ortyomka ortyomka merged commit da2cabd into master Dec 1, 2021
@ortyomka ortyomka deleted the testing/miner-deal branch December 1, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants