Add option to specify bootstrap addresses #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Feb 16, 2022
| @@ -87,6 +89,15 @@ func NewHost(priv crypto.PrivKey, listenAddrs []multiaddr.Multiaddr) (host.Host, | |||
| return host, nil | |||
| } | |||
|
|
|||
| func bootstrapHost(host host.Host, btstrp []peer.AddrInfo) (io.Closer, error) { | |||
| bCfg := bootstrap.DefaultBootstrapConfig | |||
| bCfg.MinPeerThreshold = 1 | |||
There was a problem hiding this comment.
should this be the number of items in the btstrp?
There was a problem hiding this comment.
TLDR; not sure.
That determines how many bootstrap connections to open. In the case of Pando integration it will most likely remain to 1. Though I am not sure what the future brings. Setting that to the length of addrinfos when a lot of addresses are provided might have unintended consequences.
The default value for this is 4. I'll leave a todo to parameterise it since it is entirely application specific.
masih
force-pushed
the
masih/pando-bootstrap
branch
2 times, most recently
from
df59be7
to
862ccd9
Compare
Allow the libp2p host to optionally perform bootstrap with given list of addinfos.
masih
force-pushed
the
masih/pando-bootstrap
branch
from
862ccd9
to
01a6cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the libp2p host to optionally perform bootstrap with given list of
addinfos.
Relates to #342