Add Wasm support to ec-gpu-gen #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that's needed. When |
vmx
added a commit
that referenced
this pull request
Sep 20, 2022
Using resolver version 2 (which is default in Rust editiion 2021), it is possible to run `cargo build --target wasm32-unknown-unknown` without any failures. Note that even before this change it was possible when `ec-gpu-gen` was used as a dependency, but with this change it becomes more apparent. The problem was that the `rand` dev-dependency was enabling the `std` feature, which then led to `ff` pulling is `getrandom`, which has problems to be compiled to `wasm32-unknown-unknown` without setting the `js` feature. Closes #32.
|
@samuelburnham I've created #33 to make things more apparent. |
vmx
added a commit
that referenced
this pull request
Sep 21, 2022
Using resolver version 2 (which is default in Rust editiion 2021), it is possible to run `cargo build --target wasm32-unknown-unknown` without any failures. Note that even before this change it was possible when `ec-gpu-gen` was used as a dependency, but with this change it becomes more apparent. The problem was that the `rand` dev-dependency was enabling the `std` feature, which then led to `ff` pulling is `getrandom`, which has problems to be compiled to `wasm32-unknown-unknown` without setting the `js` feature. BREAKING CHANGE: the workspace resolver was updated to v2 Closes #32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the following command to build:
It also supports the
cudafeature, but notopencldue to its dependency onlibc.This would move
bellperson'sgetrandomdependency toec-gpu-gen, and at least in theory would allow the former to use CUDA on Wasm. In practice it doesn't yet work due to thefs2dependency, but if it's useful maybe that can be fixed.