chore: make version part of the release commit #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour of cargo release changed in v0.25. When there is a workspace, it now consolidates all changes into a single commit by default. This means that the commit message can't contain the version number of a specific crate. With adding a relase.toml file with the `consolidate-commits = false` options restores the old behaviour and you get separate commits. We release those two crates separatly anyway. I decided to use the release.toml file instead of putting it into the Cargo.toml, to make it clearer that we use custom cargo-release options. This can easily be overlooked if it's just a value in the Cargo.toml.
|
I dare to merge that without a review as it isn't a code change, but it's about releasing things. It can also be changed again after the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of cargo release changed in v0.25. When there is a workspace, it now consolidates all changes into a single commit by default. This means that the commit message can't contain the version number of a specific crate.
With adding a relase.toml file with the
consolidate-commits = falseoptions restores the old behaviour and you get separate commits. We release those two crates separatly anyway.I decided to use the release.toml file instead of putting it into the Cargo.toml, to make it clearer that we use custom cargo-release options. This can easily be overlooked if it's just a value in the Cargo.toml.