Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Organize consensus code for shards #26

Closed
Tracked by #28
adlrocha opened this issue Oct 1, 2021 · 0 comments
Closed
Tracked by #28

Organize consensus code for shards #26

adlrocha opened this issue Oct 1, 2021 · 0 comments

Comments

@adlrocha
Copy link
Collaborator

adlrocha commented Oct 1, 2021

We currently support exclusively delegated consensus in shards, so much of the code in https://github.com/filecoin-project/eudico/blob/sharding/chain/sharding/genesis.go is exclusive for delegated consensus.

We should:

  • Extract this code so we have implementation for every consensus we will support in shards.
  • Fix hard-coded variables and get them from the actor initialization.
  • In
    func (sh *Shard) mineDelegated(ctx context.Context) error {
    there is a lot of duplicate code from DelegatedMinerCmd. Consider extracting this into a package that both can use (I think it make sense adding it to the consensus package).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant