Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for mainnet params #2243

Closed
wants to merge 1 commit into from

Conversation

f8-ptrk
Copy link
Contributor

@f8-ptrk f8-ptrk commented Mar 3, 2024

update mainent boostrap peer list to current lotus/v1.15.2 branch ones

update mainent boostrap peer list to current lotus/v1.15.2 branch ones
@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Mar 3, 2024

@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Mar 3, 2024

lets not play the game again - change the PR as needed to pass the checks... thx

@f8-ptrk f8-ptrk changed the title Update README.md Update README.md for mainnet params Mar 3, 2024
@jennijuju
Copy link
Member

need to update to release/v1.26.0 ones

@smagdali
Copy link
Collaborator

So they should be these instead?
https://github.com/filecoin-project/lotus/blob/release/v1.26.0/build/bootstrap/mainnet.pi

btw there was an obviously typo 'bootstarp' on the current commit.

@eshon
Copy link
Collaborator

eshon commented Jun 19, 2024

@f8-ptrk

  • Why is it necessary to list bootstrap peers in a separate place like the Filecoin Docs?

@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Jun 19, 2024

is isn't. but if we do it they need to be correct

@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Jun 19, 2024

it needs a source of truth for these things - the lotus code i think - and if we display the information somewhere else we should "pull" the lotus code - i agree

@eshon
Copy link
Collaborator

eshon commented Jun 19, 2024

@f8-ptrk - Why pull the Lotus code? Why not just link to it from the Docs? Like this:

"Bootstrap peers for current mainnet can be found at:

https://github.com/filecoin-project/lotus/blob/release/[latest release]/build/bootstrap/mainnet.pi

The latest release can be found at https://github.com/filecoin-project/lotus/releases/latest/

Is that sufficient?

Like otherwise it seems circular that we want to list them here but originally also get them from Lotus source code.

@f8-ptrk
Copy link
Contributor Author

f8-ptrk commented Jun 19, 2024

it is sufficient

everything that doesn't show wrong data is sufficient

@eshon
Copy link
Collaborator

eshon commented Jun 20, 2024

Replaced by #2265

@eshon eshon closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants