-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fauxrep2 to api #124
Conversation
This PR is incomplete in that the tests cannot be run because |
That sounded like an issue I'm good at figuring out. Half an hour later it runs for me (though I have too little clue about Go/CGo, so I can't really verify if it does the right thing). Works on my Debian testing:
|
I still cannot use it as on my system rerunning it results with every uint64 being replace with uint. Maybe someone should try on OSX. |
@vmx |
@vmx Scratch that! So the |
@cryptonemo Though I'm seeing the same |
I propose letting someone on OSX run that (without modifications first) and see if that works. If it doesn't work, fixing it couldn't be to hard (esp. if you know Go ;) |
@vmx Ok. Does anyone on this PR/thread have OS X to run this on though? It's probably pretty important that someone here can get this going w/o too much issue in the future. |
I looked at this a bit and we can actually use the standard c-for-go version to process the |
So the difference seems to be that osx is using |
Though it transforms from our own |
Maybe linux declares |
For me |
I don't know if that's really the core file of GCC where things are defined. but here https://github.com/gcc-mirror/gcc/blob/f6fe3bbf9f6c0b7249933e19b94560b6b26bf269/libphobos/libdruntime/core/stdc/stdint.d I can see:
That sucks. |
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
, Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@Kubuxu Do I understand it correctly that your c-for-go fork just applied xlab/c-for-go#91? So if we can get that one merged upstream, we could switch back to that? |
Yeah, it is just that. |
feat: update dependencies (including proofs)