Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update proofs release to latest #146

Merged
merged 11 commits into from
Oct 28, 2020
Merged

fix: update proofs release to latest #146

merged 11 commits into from
Oct 28, 2020

Conversation

cryptonemo
Copy link
Contributor

No description provided.

@cryptonemo
Copy link
Contributor Author

@magik6k @Kubuxu The CI may not quite be happy, but this is the PR to test out for picking up the new proofs release.

porcuquine
porcuquine approved these changes Oct 13, 2020
View reviewed changes
Copy link

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. If CI passes and downstream builds, seems fine.

@cryptonemo
Copy link
Contributor Author

@magik6k @Kubuxu CI is good now except for a go_lint failure -- if this is something you can handle (or ignore), it would be appreciated.

@cryptonemo cryptonemo mentioned this pull request Oct 15, 2020
Closed
@cryptonemo
Copy link
Contributor Author

@Kubuxu Pretty sure it's just failing because of the LD_LIBRARY_PATH not being set. Slack is delaying my responses. Unfortunately, the hwloc lib is not statically linked like I was hoping, and there is a lead on the rust bindings to help it, but it's not happening immediately.

@cryptonemo
Copy link
Contributor Author

I'll push an update to test that out shortly @magik6k @Kubuxu

@cryptonemo
Copy link
Contributor Author

Hrm, ok, maybe it is go related: dominikh/go-tools#646 Not entirely sure what this means yet.

@cryptonemo
Copy link
Contributor Author

Based on lotus testing, I am linking a possible neptune version issue with this PR: filecoin-project/rust-fil-proofs#1320 (comment)

@cryptonemo
Copy link
Contributor Author

@magik6k @Kubuxu Any chance we can get lotus re-testing with this? This updates neptune and somehow fixed the go-lint issue (?) -- perhaps people with PC1 problems will have better luck now.

@magik6k magik6k mentioned this pull request Oct 27, 2020
Merged
3 tasks
magik6k
magik6k approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seems to work pretty well in testing

@magik6k magik6k merged commit 0226d0b into master Oct 28, 2020
@cryptonemo cryptonemo deleted the release-update branch October 28, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptonemo @porcuquine @magik6k