Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocator create logic #125

Merged
merged 6 commits into from
Feb 19, 2024
Merged

allocator create logic #125

merged 6 commits into from
Feb 19, 2024

Conversation

kokal33
Copy link
Contributor

@kokal33 kokal33 commented Feb 16, 2024

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Additionally, please provide context necessary to understand why these changes were made and how they address the issue.

Fixes # (issue reference)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Before submitting your pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

Any additional information, configuration, or data that might be necessary to reproduce the issue or test the feature.

Copy link
Collaborator

@clriesco clriesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clriesco clriesco merged commit fee8f92 into main Feb 19, 2024
1 check passed
@clriesco clriesco deleted the feat/create-or-update-allocator branch February 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants