-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple feats #186
Multiple feats #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for testing. See attached comments before going to prod
new_allocation_amount: Option<String>, | ||
) -> Result<(), LDNError> { | ||
let blockchain = BlockchainData::new(); | ||
match blockchain.get_allowance_for_address("f24siazyti3akorqyvi33rvlq3i73j23rwohdamuy").await { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave this as it is just for testing purposes. We need to remove it when tagging into prod
}, | ||
}; | ||
|
||
println!("==============================="); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove prints on tagging
match compare_allowance_and_allocation(&allowance, new_allocation_amount) { | ||
Some(result) => { | ||
if result { | ||
println!("Allowance is sufficient."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove prints on tagging
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Additionally, please provide context necessary to understand why these changes were made and how they address the issue.
Fixes # (issue reference)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
Before submitting your pull request, please review the following checklist:
Additional Information
Any additional information, configuration, or data that might be necessary to reproduce the issue or test the feature.