enforce that the trailing bits of an address string are standard #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jun 8, 2022
address.go
Outdated
| @@ -323,6 +323,11 @@ func decode(a string) (Address, error) { | |||
| return Undef, err | |||
| } | |||
|
|
|||
| reencodedRaw := AddressEncoding.WithPadding(-1).EncodeToString(payloadcksm) | |||
| if reencodedRaw != raw { | |||
| return Undef, ErrInvalidChecksum | |||
There was a problem hiding this comment.
We should make a new error. The checksum isn't invalid, it's just not a "standard" encoding.
There was a problem hiding this comment.
Yeah, I was too lazy to do that. Done.
arajasek
force-pushed
the
asr/decode-encode
branch
2 times, most recently
from
9511633
to
75e7600
Compare
arajasek
force-pushed
the
asr/decode-encode
branch
from
75e7600
to
58f4b3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 47.63% 48.24% +0.61%
==========================================
Files 4 4
Lines 338 342 +4
==========================================
+ Hits 161 165 +4
Misses 151 151
Partials 26 26
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22