fix: reset leaf node bitmap on flush #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush()
rebuilds the serializable form of the node and, setting theValues
array for leaves andLinks
for non-leaves, in the process it sets up the bitmap again for each set element. On the non-leaf nodes we get a fresh bitmap to work with but the same is not done on leaf nodes.I'm not convinced this is strictly necessary since
setBit()
andclearBit()
are called on mutations elsewhere, but as long as we're doing a fresh rebuild and it's being done for non-leaf nodes, this should be done here to be absolutely sure, otherwise then.setBit(i)
isn't necessary either.