fix: skip traversal of links with the same cid #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 62.60% 62.65% +0.05%
==========================================
Files 9 9
Lines 1345 1347 +2
==========================================
+ Hits 842 844 +2
Misses 351 351
Partials 152 152
|
JesseXie
approved these changes
May 11, 2023
frrist
reviewed
May 12, 2023
| @@ -263,6 +263,9 @@ func diffNode(ctx context.Context, prevCtx, curCtx *nodeContext, prev, cur *node | |||
| } | |||
|
|
|||
| // Both previous and current have links to diff | |||
| if prev.links[i].cid == cur.links[i].cid { | |||
There was a problem hiding this comment.
Similar to my comment in the HAMT change, use the Equals method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load tested with AMT that has 1M values and random 10 changes to mimic chain state changes.
Here's some stats:
1075ms -> 0.7ms900ms -> 0.5ms757ms -> 1.5 ms638ms -> 0.6ms996ms -> 1ms