blocked: import go-ipld-cbor interface #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
commented
Jan 30, 2020
go.mod
Outdated
Comment on lines
18
to
19
|
|
||
| replace github.com/ipfs/go-ipld-cbor => ../../ipfs/go-ipld-cbor |
There was a problem hiding this comment.
will remove before merging
anorth
approved these changes
Jan 30, 2020
amt.go
Outdated
| } | ||
| } | ||
|
|
||
| func LoadAMT(bs Blocks, c cid.Cid) (*Root, error) { | ||
| func LoadAMT(bs cbor.CborIpldStore, c cid.Cid) (*Root, error) { |
There was a problem hiding this comment.
This should really take a context parameter.
anorth
reviewed
Jan 30, 2020
go.mod
Outdated
| @@ -3,14 +3,17 @@ module github.com/filecoin-project/go-amt-ipld/v2 | |||
| go 1.12 | |||
|
|
|||
| require ( | |||
| github.com/ipfs/go-block-format v0.0.2 | |||
| github.com/filecoin-project/go-amt-ipld v1.0.0 | |||
There was a problem hiding this comment.
It is importing older version. It should not.
go.mod
Outdated
| github.com/stretchr/testify v1.3.0 | ||
| github.com/whyrusleeping/cbor-gen v0.0.0-20190917003517-d78d67427694 | ||
| golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 | ||
| github.com/warpfork/go-wish v0.0.0-20200122115046-b9ea61034e4a // indirect |
There was a problem hiding this comment.
Commentary: it would be very valuable to scope down the dependencies of go-ipld-cbor to avoid large amounts of code being pulled into things like Filecoin.
frrist
force-pushed
the
frrist/import-cbor-store
branch
from
50c560d
to
d7ff21e
Compare
| } | ||
| if err := cbg.GenTupleEncodersForType(amt.Node{}, fi); err != nil { | ||
| // FIXME this will not generate the correct code, leave the cbor_gen.go file untouched. | ||
| if err := cbg.WriteMapEncodersToFile("cbor_gen.go", "amt", amt.Root{}, amt.Node{}); err != nil { |
There was a problem hiding this comment.
should also be 'Tuple' instead of Map here
whyrusleeping
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on ipfs/go-ipld-cbor#70