Use time-based counter instead of stored counter for transfer ID #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/remove-stored-counter
branch
from
e473792
to
1bee82b
Compare
dirkmc
commented
Mar 22, 2021
dirkmc
force-pushed
the
feat/remove-stored-counter
branch
from
1bee82b
to
92874c4
Compare
dirkmc
force-pushed
the
feat/remove-stored-counter
branch
from
92874c4
to
8b16747
Compare
dirkmc
changed the title
This was referenced Mar 23, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the data transfer ID is produced by an incrementing counter stored in the datastore.
The datastore state sometimes gets out of sync in real world clients. If the state gets wiped on the client, the counter starts from zero. However miners do not accept a transfer which has an existing client peer ID and transfer ID. So all transfers from that client will be rejected until the counter reaches the same level it was at before.
To avoid this problem, this PR changes the way that the transfer ID is generated: the ID is derived from the current time.