Dont double count data sent #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
fix/data-sent-size
branch
from
209dc7d
to
3c0714a
Compare
dirkmc
force-pushed
the
fix/data-sent-size
branch
from
3c0714a
to
6fd0e16
Compare
dirkmc
commented
Apr 1, 2021
Comment on lines
-37
to
-54
| if chid.Initiator != m.peerID { | ||
| var result datatransfer.VoucherResult | ||
| var err error | ||
| var handled bool | ||
| _ = m.revalidators.Each(func(_ datatransfer.TypeIdentifier, _ encoding.Decoder, processor registry.Processor) error { | ||
| revalidator := processor.(datatransfer.Revalidator) | ||
| handled, result, err = revalidator.OnPushDataReceived(chid, size) | ||
| if handled { | ||
| return errors.New("stop processing") | ||
| } | ||
| return nil | ||
| }) | ||
| if err != nil || result != nil { | ||
| msg, err := m.processRevalidationResult(chid, result, err) | ||
| if msg != nil { | ||
| if err := m.dataTransferNetwork.SendMessage(context.TODO(), chid.Initiator, msg); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Note: the logic hasn't changed here, just the indentation.
I suggest viewing with whitespace changes turned off:
https://github.com/filecoin-project/go-data-transfer/pull/185/files?diff=unified&w=1
aarshkshah1992
approved these changes
Apr 2, 2021
This was referenced May 6, 2021
Merged
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
Tasks: