-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graphsync to 2.0 branch - absolute minimum #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the absolute minimum required to work with the latest version of graphsync with the 2.0 protocl. This does use a very unfortunate hack to deal with the change to extension type -- it now deserializes/serializes from basicnode.Any in order to get back to a []byte type
This was referenced Feb 18, 2022
6 tasks
no longer need to utilize peer id to tract graphsync requests since RequestIDs are unique
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 67.58% 66.06% -1.52%
==========================================
Files 24 29 +5
Lines 3159 3439 +280
==========================================
+ Hits 2135 2272 +137
- Misses 678 814 +136
- Partials 346 353 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Get us to compatibility with the graphsync 2.0 branch with the absolute minimum number of changes. We'd like very much not to stay here -- but this is a starting point. It resolves at minimum the API changes, without addressing more significant issues around message encoding to IPLD
Implementation