Minor fixes for retrieval on data transfer #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use both type registries to decode vouchers in channels
rather than clunky noopSynchronize event, use built in GetSync method in go-statemachine
Not sure how this was managing to work given how it's written!
was failng in situations with where request completed, due to timing issues.
hannahhoward
force-pushed
the
feat/fixes-for-retrieval
branch
from
c44c30e
to
3e522cc
Compare
make sure the revalidation sends a different message for a response that is finalizing versus regular
do not cleanup channels until transfer is definitely complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Various fixes / adds discovered in the course of putting retrieval on data transfer
Implementation