Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pull Request Cancelling #67

Merged
merged 2 commits into from Aug 21, 2020
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

Currently, closing the data transfer on a pull request would always hang or return an error

Implementation

  • add tests for channel closing on the responder side (w/ paused channel)
  • fix some state machine stuff that led to a statemachine error after request completed
  • fix the underlying locking issue (holding lock too long) that led to close call hanging

Sidebar:

  • also adds a test to verify ability to send the same data to many people at once -- this was something I wrote earlier but never committed

Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix a lock held to long that was causing an error for closing a data transfer channel
@hannahhoward hannahhoward merged commit c6b4d74 into master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants