-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Fuzz honest multi-instance to avoid intermittent failures #277
Conversation
Fuzz test failed on commit 9b03360. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9229354426 -n testdata Aleternatively, download directly from here. |
9b03360
to
cf85d02
Compare
Fuzz test failed on commit cf85d02. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9229469451 -n testdata Aleternatively, download directly from here. |
cf85d02
to
e41ecee
Compare
`FuzzHonestMultiInstance_AsyncAgreement` intermittently fails on CI, most likely due to taking too long to complete a test. To avoid intermittent failures: * change the honest multi instance tests to cover incremental network sizes, up to 4 * reduce the length of randomly generated EC chains at each instance as this should not affect the test quality for what it is testing. But it should make it run faster due to less GC. Additionally, add static corpus that failed locally after extended fuzz time to the fuzz test. Fixes #251
96e0f1d
to
10c5d22
Compare
I have fuzzed the changes here in CI, specifically for That gives me confidence that the change here would resolve the issue without affecting coverage. |
We could probably skip network sizes 1 and 2, and maybe 3. 4 is much more useful, and anything a bit larger would be handy too. But I understand the duration limitations. A quick look at optimising could be worthwhile. |
FuzzHonestMultiInstance_AsyncAgreement
intermittently fails on CI, most likely due to taking too long to complete a test.To avoid intermittent failures:
Additionally, add static corpus that failed locally after extended fuzz time to the fuzz test.
Fixes #251