Skip messages from the wrong instance instead of returning an error #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to async message delivery, we'll frequently get messages from the wrong instance. Log (trace) and drop them. Part of #421.
masih
reviewed
Jul 10, 2024
|
Ah, well, I need to fix the tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 75.46% 68.60% -6.86%
==========================================
Files 42 46 +4
Lines 3786 4530 +744
==========================================
+ Hits 2857 3108 +251
- Misses 644 894 +250
- Partials 285 528 +243
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to async message delivery, we'll frequently get messages from the wrong instance. Log (trace) and drop them.
Part of #421.