Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support selectors on retrieval #187

Merged
merged 2 commits into from Apr 8, 2020
Merged

Support selectors on retrieval #187

merged 2 commits into from Apr 8, 2020

Conversation

shannonwells
Copy link
Contributor

Closes #170

Change summary

  • Decode selector in client.Receive and if valid, pass to the block SelectorVerifier
  • Decode selector when creating a new provider, and if valid, pass to the SelctorBlockReader
  • Add 2 unit tests, one that uses the allselector and one that selects some

hannahhoward
hannahhoward approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit a2909ce into master Apr 8, 2020
@shannonwells shannonwells deleted the feat/#170 branch April 23, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieval Deals Support Selectors
2 participants
@shannonwells @hannahhoward