Round-trip storage/retrieval test #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move TestPeerResolver to shared testutils * make everybody specify the path to their fixture file starting from root, so >1 package can use LoadUnixFSFile * export AllSelector * please the linter
shannonwells
force-pushed
the
feat/storage-retrieval-roundtrip-#74
branch
from
7f53f8e
to
acf443b
Compare
ingar
reviewed
May 7, 2020
| @@ -7,7 +7,7 @@ import ( | |||
| "github.com/ipld/go-ipld-prime/traversal/selector/builder" | |||
| ) | |||
|
|
|||
| func allSelector() ipld.Node { | |||
| func AllSelector() ipld.Node { | |||
There was a problem hiding this comment.
Seems like while you are exporting this, this is code snippet is used all over the place in tests and in the storage market...
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 66.03% 66.43% +0.41%
==========================================
Files 40 39 -1
Lines 2269 2237 -32
==========================================
- Hits 1498 1486 -12
+ Misses 657 636 -21
- Partials 114 115 +1
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need a storage-retrieval round trip integration test. Closes #74
Change Summary:
LoadUnixFSFilehave to specify the path to their fixture file, starting from package root, so it can be used more easily by different packages.More detail about the integration test:
This is essentially the combined storage and retrieval integration tests, with most assertions removed and the remaining ones converted to requires. For retrieval code, the integration test code is converted to use the test harness method in storage integration test, in particular so the LibP2PTestData can be shared from the storage to the retrieval harness, as well as other things such as the Payload CID, so that the stored file can be retrieved.