Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal Decision Custom Function #262

Merged
merged 5 commits into from May 20, 2020
Merged

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented May 20, 2020

Goals

Provides same functionality as #260 but with setting up deal decision logic as a custom option on the provider interface, rather than altering the node interface, understanding this may be something that miners customize on an individual level

Implement

@hannahhoward hannahhoward changed the base branch from master to feat/deal-accept-interface May 20, 2020 19:42
@hannahhoward hannahhoward changed the base branch from feat/deal-accept-interface to master May 20, 2020 19:43
@codecov-commenter
Copy link

Codecov Report

Merging #262 into master will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   65.04%   64.95%   -0.09%     
==========================================
  Files          39       39              
  Lines        2288     2302      +14     
==========================================
+ Hits         1488     1495       +7     
- Misses        683      690       +7     
  Partials      117      117              
Impacted Files Coverage Δ
storagemarket/impl/provider.go 5.40% <0.00%> (-0.16%) ⬇️
storagemarket/impl/providerstates/provider_fsm.go 100.00% <ø> (ø)
storagemarket/types.go 33.34% <ø> (ø)
...oragemarket/impl/providerstates/provider_states.go 85.36% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950d428...64976dc. Read the comment docs.

@hannahhoward hannahhoward merged commit 0f56af3 into master May 20, 2020
@whyrusleeping whyrusleeping deleted the feat/deal-accept-custom-function branch May 20, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants