Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deal creation time to deals #373

Merged
merged 4 commits into from Aug 14, 2020
Merged

Conversation

whyrusleeping
Copy link
Member

should help us close filecoin-project/lotus#2646

@hannahhoward
Copy link
Collaborator

LGTM not sure what you want to do about tests and time.Now -- I can take this on if you want.

@hannahhoward
Copy link
Collaborator

Sorry LGTM after tests and mod-tidy-check are passing

@codecov-commenter
Copy link

Codecov Report

Merging #373 into master will decrease coverage by 0.62%.
The diff coverage is 2.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   61.78%   61.16%   -0.61%     
==========================================
  Files          41       43       +2     
  Lines        2857     2814      -43     
==========================================
- Hits         1765     1721      -44     
- Misses        941      945       +4     
+ Partials      151      148       -3     
Impacted Files Coverage Δ
storagemarket/impl/client.go 2.90% <0.00%> (+0.18%) ⬆️
storagemarket/impl/client_environments.go 0.00% <0.00%> (ø)
storagemarket/impl/provider.go 3.01% <0.00%> (+0.48%) ⬆️
storagemarket/impl/provider_environments.go 0.00% <0.00%> (ø)
storagemarket/types.go 0.00% <ø> (ø)
...mpl/requestvalidation/unified_request_validator.go 75.00% <33.34%> (ø)
storagemarket/impl/requestvalidation/common.go 87.10% <100.00%> (-0.40%) ⬇️
piecestore/piecestore.go 38.47% <0.00%> (-26.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105c7c2...86faa64. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus client list-deals is unsorted
3 participants