Consider ClientCollateral when validating deal proposal #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
fix/validate-client-collateral-3864
branch
from
bcf46a9
to
a647860
Compare
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 44 44
Lines 2714 2714
=======================================
Hits 1661 1661
Misses 889 889
Partials 164 164
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, we weren't including the client collateral when considering storage deal proposals; it was assumed it was always 0.
Solution
Use
ClientBalanceRequirement()when verifying client funds, which includes the client collateral.Resolves filecoin-project/lotus/issues/3864