Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providers should reject deals with invalid durations #427

Merged
merged 2 commits into from Oct 13, 2020
Merged

Providers should reject deals with invalid durations #427

merged 2 commits into from Oct 13, 2020

Conversation

arajasek
Copy link
Collaborator

@arajasek arajasek commented Oct 8, 2020

@arajasek
Copy link
Collaborator Author

arajasek commented Oct 9, 2020

Can't seem to get the imports check to pass (/scripts/fiximports seems to edit very file there is)

hannahhoward
hannahhoward approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit cf74bf9 into master Oct 13, 2020
@arajasek arajasek deleted the asr/deal-duration-ux branch October 7, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

@ingar ingar Awaiting requested review from ingar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arajasek @hannahhoward